Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 (rebased) #700

Merged
merged 7 commits into from Sep 29, 2018

Conversation

2 participants
@f3l1x
Copy link
Member

f3l1x commented Sep 8, 2018

Rebased #699 without merge commits and conflicts.

BC break: dropped *.min.js and *.min.css

paveljanda and others added some commits Jan 8, 2018

Starting support for Bootstrap 4
# Conflicts:
#	assets/dist/datagrid.min.js

@f3l1x f3l1x force-pushed the feature/rebased-bootstrap4 branch from c637052 to 09fd65f Sep 8, 2018

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Sep 10, 2018

@f3l1x Why that BC break?

@f3l1x

This comment has been minimized.

Copy link
Member Author

f3l1x commented Sep 10, 2018

It's hard to maintain coffee -> JS -> minify, same thing for SASS -> CSS -> minify without propel scripts or sth. How have you done until now?

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Sep 10, 2018

Using one old gulpfile..

  • Can't github CI do something like that? -> Starting docker-compose based configuration and build a minified assetets inside it?

Hm, it really should not be a part of the vendor. Ok, good. 👍

@f3l1x f3l1x referenced this pull request Sep 19, 2018

Closed

Bootstrap 4 #699

@f3l1x f3l1x added this to the v5.7 milestone Sep 29, 2018

@f3l1x f3l1x added the enhancement label Sep 29, 2018

@f3l1x f3l1x merged commit 29915f0 into v5.x Sep 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@f3l1x f3l1x referenced this pull request Sep 29, 2018

Closed

Bootstrap 4 Support #416

@f3l1x f3l1x deleted the feature/rebased-bootstrap4 branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.