Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.1 type declarations #2

Closed
paveljanda opened this issue Jun 8, 2017 · 4 comments

Comments

3 participants
@paveljanda
Copy link
Member

commented Jun 8, 2017

@f3l1x Would you appreciate a PR with PHP 7.1 type declarations and strict_types declared in each file?

@f3l1x

This comment has been minimized.

Copy link
Member

commented Jun 8, 2017

Yes, I would, but we have to wait until 2018, because this whole concept is used in one of my company and they'll use PHP 5.6 until end of 2017. It's only a few months. :-)

@paveljanda

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2017

Creating new branch (php71 or v2 :P) would fix that..

@f3l1x

This comment has been minimized.

Copy link
Member

commented Jun 8, 2017

Sure, but I don't want to waste time to maintenance 2 branches. :-)

@paveljanda

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2017

I understand. Ping me in that issue when you're ready. :)

@f3l1x f3l1x added this to the v1.0 milestone Aug 3, 2017

@f3l1x f3l1x closed this in #13 Jun 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.