upgrade PHPStan

Author: petrparolek

Makefile

@@ -12,7 +12,7 @@ csf:
 	vendor/bin/codefixer src tests
 
 phpstan:
-	vendor/bin/phpstan analyse -l max -c phpstan.neon src
+	vendor/bin/phpstan analyse -l 8 -c phpstan.neon src
 
 tests:
 	vendor/bin/tester -s -p php --colors 1 -C tests/cases

composer.json

@@ -22,14 +22,14 @@
     "nette/neon": "^3.0.0"
   },
   "require-dev": {
-    "composer/composer": "^1.6.3",
+    "composer/composer": "^1.6.3|^2.0",
     "mockery/mockery": "^1.3.0",
     "ninjify/nunjuck": "^0.4",
     "ninjify/qa": "^0.12",
-    "phpstan/phpstan": "^0.12",
-    "phpstan/phpstan-deprecation-rules": "^0.12",
-    "phpstan/phpstan-nette": "^0.12",
-    "phpstan/phpstan-strict-rules": "^0.12"
+    "phpstan/phpstan": "^1.0",
+    "phpstan/phpstan-deprecation-rules": "^1.0",
+    "phpstan/phpstan-nette": "^1.0",
+    "phpstan/phpstan-strict-rules": "^1.0"
   },
   "autoload": {
     "psr-4": {

phpstan.neon

@@ -8,6 +8,7 @@ parameters:
 	ignoreErrors:
 		# phpstan error
 		- '#^Strict comparison using === between string and false will always evaluate to false.#'
+		- '#^Binary operation "." between non-empty-string and array\|bool\|float\|int\|string\|null results in an error#'
 
 		# too lazy to solve
 		- '#^Construct empty\(\) is not allowed\. Use more strict comparison\.$#'

src/Decoder/DecoderFactory.php

@@ -7,7 +7,7 @@
 class DecoderFactory implements IDecoderFactory
 {
 
-	/** @var string[] */
+	/** @var array<string, class-string<IDecoder>> **/
 	private $decodersMap = [
 		'json' => JsonDecoder::class,
 		'neon' => NeonDecoder::class,

src/Encoder/EncoderFactory.php

@@ -7,7 +7,7 @@
 class EncoderFactory implements IEncoderFactory
 {
 
-	/** @var string[] */
+	/** @var array<string, class-string<IEncoder>> **/
 	private $encodersMap = [
 		'json' => JsonEncoder::class,
 		'neon' => NeonEncoder::class,

src/TaskSet.php

@@ -72,8 +72,6 @@ public function set(array $args): void
 		foreach ($input->getOptions() as $key => $value) {
 			// Black magic. It parse --database.host=localhost into $tmp array.
 			// Easy to use! :-)
-			/** @var string $value */
-			$value = $value;
 			parse_str('parameters[' . str_replace('.', '][', $key) . ']=' . $value, $tmp);
 
 			// Merge user inputs