Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement NeonizerExtension::validate #2
Sorry @jiripudil it takes so long time. I'm not sure how to say, but I'm not sure if it's should be implement it in this way. I mean, it's not wrong and it deserve to be merged. There's some tiny detail,
What about move FileLoader into Decoder class? And DecoderFactory will be responsible to setup proper FileLoader. For example:
Frankly, I don't like that idea. The code would be where it was prior to this PR, but with an object wrapper over
FileLoader was just a result of extracting a piece of code that would be unnecessarily duplicated. I understand you are uneasy about it, and I don't want to spend too much time inventing abstractions, so I've just reverted that part of the commit.