Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP >= 7.1 compatible release #2

Merged
merged 11 commits into from May 7, 2018

Conversation

3 participants
@mabar
Copy link
Member

commented Feb 19, 2018

Dropped compatibility with php 5.6 and 7.0
Added strict types
Latest symfony/console allowed
Dropped unuseful annotations (where were same as php native typehint)
Replaced DateTime with DateTimeInterface - not possible, not supported by https://github.com/dragonmantank/cron-expression

@f3l1x f3l1x added this to the v0.2 milestone Feb 20, 2018

@f3l1x f3l1x added the enhancement label Feb 20, 2018

@f3l1x

This comment has been minimized.

Copy link
Member

commented Feb 20, 2018

Thanks. :-) I've released v0.1 with PHP 5.6, for our old systems and >=0.2 will be PHP 7.1 only.

@f3l1x

This comment has been minimized.

Copy link
Member

commented May 7, 2018

Please, upgrade to latest ninjify/qa to complete this PR. :-) Good job btw.

@coveralls

This comment has been minimized.

Copy link

commented May 7, 2018

Coverage Status

Coverage remained the same at 29.839% when pulling 8622cca on mabar:master into cd4b134 on contributte:master.

"ninjify/qa": "~0.4.0",
"mockery/mockery": "~1.0",
"phpunit/phpunit": "~5.7.26"
"ninjify/qa": "~0.8.0",

This comment has been minimized.

Copy link
@f3l1x

f3l1x May 7, 2018

Member

"ninjify/qa": "^0.8.0"

"ninjify/qa": "~0.8.0",
"mockery/mockery": "~1.0.0",
"phpunit/phpunit": "~5.7.27",
"tracy/tracy": "2.4.9"

This comment has been minimized.

Copy link
@f3l1x

f3l1x May 7, 2018

Member

"tracy/tracy": "~2.4.14"

* @return string[]
*/
private static function formatRow($key, IJob $job, DateTime $dateTime)
private static function formatRow(string $key, IJob $job, DateTime $dateTime): array

This comment has been minimized.

Copy link
@f3l1x

f3l1x May 7, 2018

Member

Move it to the end of the file.

{
if (class_exists('\Tracy\Debugger')) {
\Tracy\Debugger::log($e);
if (class_exists(TracyDebugger::class)) {

This comment has been minimized.

Copy link
@f3l1x

f3l1x May 7, 2018

Member

Does it really works without the tracy/tracy package? I'm not sure. Have you tested it?

This comment has been minimized.

Copy link
@mabar

mabar May 7, 2018

Author Member

Yes, autoloading is not triggered by use statements, safe to use everywhere :)

This comment has been minimized.

Copy link
@f3l1x

f3l1x May 7, 2018

Member

Cool. thanks.

mabar added some commits May 7, 2018

@f3l1x f3l1x merged commit d7b4a76 into contributte:master May 7, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.