Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list command on empty key #4

Merged
merged 2 commits into from Jun 5, 2018

Conversation

2 participants
@martingold
Copy link
Contributor

commented Jun 1, 2018

The list command was failing when custom jobs did not have set key in config and the key was not passed to Schedulers add method so it was impossible to use custom jobs. Now if the key is not set, it just does not print anything in key column.

 Type error: Argument 1 passed to Contributte\Scheduler\Command\ListCommand::formatRow() must be of the type string, integer given, called in vendor/contributte/scheduler/src/Command  
  /ListCommand.php on line 40

@f3l1x f3l1x merged commit 7552e3e into contributte:master Jun 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 29.839%
Details
@f3l1x

This comment has been minimized.

Copy link
Member

commented Jun 5, 2018

Thank you.

@f3l1x f3l1x added this to the v0.3 milestone Jun 5, 2018

@f3l1x

This comment has been minimized.

Copy link
Member

commented Jun 10, 2018

Released v0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.