Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add samples for OK and INFO severity #1163

Open
abhinayagarwal opened this issue Jun 1, 2019 · 1 comment

Comments

@abhinayagarwal
Copy link
Collaborator

@abhinayagarwal abhinayagarwal commented Jun 1, 2019

Add samples for the changes done in PR #1110.

This can be done by updating HelloValidation class, if required.

@Mason-Chou

This comment has been minimized.

Copy link
Contributor

@Mason-Chou Mason-Chou commented Oct 22, 2019

My PR only covers the bare minimum to work onto this issue. We might need to add more factory methods in Validator class for ease of use on the developer. From my experience, it's hard to add a "negated" condition as a validator. Example would be, I want an Error Severity on a TextField when it has no value but I want a INFO Severity when the user input the value Test.

Maxoudela added a commit that referenced this issue Nov 5, 2019
PR for Issue #1163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.