Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1114 Notifications: Fix notifications position #1132

Merged

Conversation

Projects
None yet
2 participants
@Ciruman
Copy link
Contributor

commented Apr 5, 2019

The position of the elements does not use the notification position
anymore. It uses the position where the notifications will be shown.

The following errors are fixed with this change:

  • Fix old notifications shown not aligned with new notifications
    when the window is moved or owner is set.
  • Fix animation, it does not use the position of the notification
    because if the animation is not finished, the position is not
    correct. Previously, the position between the first and second
    notification was not right if there were several notifications.

This is the fix for the problem in Notifications position.

Issue: #1114(#1114)

New features/fixes easily reproducible with HelloNotifications class:

New notifications are aligned with the old ones.
All notifications are correctly aligned.
the functionality was tested in GNU/Linux, Windows and Mac. In Windows, if the notification is shown with an owner, and the owner is moved, the following notifications will be correctly aligned.

#1114 Notifications: Fix notifications position
The position of the elements does not use the notification position
anymore. It uses the position where the notifications will be shown.

The following errors are fixed with this change:
- Fix old notifications shown not aligned with new notifications
when the window is moved
- Fix animation, it does not use the position of the notification
because if the animation is not finished, the position is not
correct. Previously, the position between the first and second
notification was not right if there were several notifications.
@Ciruman

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

@abhinayagarwal abhinayagarwal merged commit 6ac1549 into controlsfx:master May 11, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.