Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with Gradle 5 #1174

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@martinfrancois
Copy link
Contributor

commented Jul 20, 2019

Fix #1172

The left shift operator (<<) is deprecated since Gradle 3.2 and was removed from Gradle 5. With the left shift operator, controlsfx will not build using Gradle 5. I replaced it with the doLast block, which makes it build again with Gradle 5.

replace left shift operator with `doLast` block
the left shift operator is deprecated since Gradle 3.2 and was removed from Gradle 5. With the left shift operator, controlsfx will not build using Gradle 5.
@martinfrancois

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

Can somebody please re-run the failing build? I don't think the failure is related to my changes, as the other one is passing.

@abhinayagarwal

This comment has been minimized.

Copy link
Collaborator

commented Jul 21, 2019

@martinfrancois The failed Travis pipeline shouldn't have run at all. I had missed to remove the same from the repository settings. The PR should pass here and it does.

@abhinayagarwal abhinayagarwal merged commit 5d00440 into controlsfx:master Jul 21, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@martinfrancois martinfrancois deleted the martinfrancois:fixGradle5Build branch Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.