Permalink
Browse files

Rohit/Akriti Fixed backbone issue with click handler of share button,…

… removed unused files
  • Loading branch information...
1 parent 88bfafa commit 8f2b48c1667cb194d0f461e9113eb9b7008fc02f @rohitggarg rohitggarg committed Feb 28, 2013
@@ -6,7 +6,7 @@ $ ->
class FacebookFriendView extends Backbone.View
tagName: 'li'
events:
- 'click.share-button': 'shareToFriend'
+ 'click .share-button': 'shareToFriend'
initialize: ->
@model.on('change', @render, this)
@@ -1,5 +0,0 @@
-$ ->
- class SharingMessage extends Backbone.Model
- content: ->
- @get('msg') ? ''
- app.models.SharingMessage = SharingMessage
@@ -46,7 +46,7 @@ def facebook_friends(compId)
FbGraph::Query.new('select uid, name, work.employer.id from user where uid in (select uid2 from friend where uid1=me())').
fetch(self.facebook_access_token).each do|f|
if(f[:work].collect {|a| a[:employer]}.collect {|a| a[:id]}.include?(compId))
- friends[f[:uid]] = { id: f[:uid], name: f[:name] }
+ friends[f[:uid].to_s] = { id: f[:uid], name: f[:name] }
end
end
else
@@ -1,5 +0,0 @@
-describe "SharingMessage ", ->
-
- it "should get empty msg by default", ->
- sharingMessage = new app.models.SharingMessage
- expect(sharingMessage.content()).toBe('')

3 comments on commit 8f2b48c

Owner

woodhull replied Mar 4, 2013

We have js specs now? Awesome! How do they work??

Contributor

rohitggarg replied Mar 4, 2013

Owner

woodhull replied Mar 6, 2013

I've added a tech task card for this.

Please sign in to comment.