Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Rohit/Akriti Fixed backbone issue with click handler of share button,…

… removed unused files
  • Loading branch information...
commit 8f2b48c1667cb194d0f461e9113eb9b7008fc02f 1 parent 88bfafa
@rohitggarg rohitggarg authored
View
2  app/assets/javascripts/facebook_share_widget/facebook_friend_view.js.coffee
@@ -6,7 +6,7 @@ $ ->
class FacebookFriendView extends Backbone.View
tagName: 'li'
events:
- 'click.share-button': 'shareToFriend'
+ 'click .share-button': 'shareToFriend'
initialize: ->
@model.on('change', @render, this)
View
5 app/assets/javascripts/facebook_share_widget/sharing_message.js.coffee
@@ -1,5 +0,0 @@
-$ ->
- class SharingMessage extends Backbone.Model
- content: ->
- @get('msg') ? ''
- app.models.SharingMessage = SharingMessage
View
2  lib/facebook_share_widget/facebook_helper.rb
@@ -46,7 +46,7 @@ def facebook_friends(compId)
FbGraph::Query.new('select uid, name, work.employer.id from user where uid in (select uid2 from friend where uid1=me())').
fetch(self.facebook_access_token).each do|f|
if(f[:work].collect {|a| a[:employer]}.collect {|a| a[:id]}.include?(compId))
- friends[f[:uid]] = { id: f[:uid], name: f[:name] }
+ friends[f[:uid].to_s] = { id: f[:uid], name: f[:name] }
end
end
else
View
5 spec/coffeescripts/sharing_message_spec.js.coffee
@@ -1,5 +0,0 @@
-describe "SharingMessage ", ->
-
- it "should get empty msg by default", ->
- sharingMessage = new app.models.SharingMessage
- expect(sharingMessage.content()).toBe('')

3 comments on commit 8f2b48c

@woodhull
Owner

We have js specs now? Awesome! How do they work??

@rohitggarg
@woodhull
Owner

I've added a tech task card for this.

Please sign in to comment.
Something went wrong with that request. Please try again.