Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greenkeeper and Renovate fail on conventional header-max-length #859

Closed
mightyiam opened this issue Nov 17, 2019 · 4 comments
Closed

Greenkeeper and Renovate fail on conventional header-max-length #859

mightyiam opened this issue Nov 17, 2019 · 4 comments

Comments

@mightyiam
Copy link
Contributor

@mightyiam mightyiam commented Nov 17, 2019

Well, both renovate and greenkeeper generate commit messages automatically. And if package names are long enough, this is what happens. And I've had that happen often.

Perhaps the conventional header-max-length could be 100?

@mightyiam mightyiam changed the title greenkeeper and renovate fail on header-max-length Greenkeeper and Renovate fail on conventional header-max-length Nov 17, 2019
@escapedcat
Copy link
Collaborator

@escapedcat escapedcat commented Nov 18, 2019

Hey @mightyiam , you could change it in your commitlint.config.js-file.
Have a look at the rules section.

@mightyiam
Copy link
Contributor Author

@mightyiam mightyiam commented Nov 18, 2019

Thank you for the tip, @escapedcat. I know I can. But I maintain numerous projects. If this is changed in @commitlint/config-conventional, then my automatic dependency updater would make a pull request for me in each of those projects and all I'd have to do is merge it. Hey, I'm just being lazy, like the rest of us.

And I do find it difficult to maintain below 72 anyway, some times.

'header-max-length': [2, 'always', 72],

I don't know the other considerations for this value. I see a request to turn this up to 100 for Angular #303 .

@escapedcat
Copy link
Collaborator

@escapedcat escapedcat commented Nov 18, 2019

Oh I see, sorry, I didn't get that you wanted to change the default as well.
Going through the linked issue and further discussions I feel like there's a PR missing just for the header but in general it looks like it was already agreed to update the default to 100.

Would you mind closing this as duplicate and move further discussion to the linked issue?

@mightyiam
Copy link
Contributor Author

@mightyiam mightyiam commented Nov 18, 2019

Duplicate of #303 .

@mightyiam mightyiam closed this Nov 18, 2019
marionebl pushed a commit that referenced this issue Feb 3, 2020
Closes #859.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.