Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: commit body should be empty by default #2980

Merged
merged 1 commit into from Jan 19, 2022
Merged

fix: commit body should be empty by default #2980

merged 1 commit into from Jan 19, 2022

Conversation

dangreen
Copy link
Contributor

@dangreen dangreen commented Jan 19, 2022

Description

commit body should be empty by default

Motivation and Context

#2971

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dangreen
Copy link
Contributor Author

@dangreen dangreen commented Jan 19, 2022

@escapedcat ping

@escapedcat
Copy link
Collaborator

@escapedcat escapedcat commented Jan 19, 2022

Thanks, would it be possible to cover this fix with a test so we won't run into this again?

@dangreen
Copy link
Contributor Author

@dangreen dangreen commented Jan 19, 2022

@escapedcat done

@escapedcat
Copy link
Collaborator

@escapedcat escapedcat commented Jan 19, 2022

Nice, thanks for the fast response!
Let's see if @honzamelena has feedback. If not I'll merge this soonish a create a new release.

@honzamelena
Copy link
Contributor

@honzamelena honzamelena commented Jan 19, 2022

@escapedcat @dangreen

LGTM

@escapedcat escapedcat merged commit e6582e0 into conventional-changelog:master Jan 19, 2022
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants