Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(load): resolve nested parser preset factories #831

Merged
merged 4 commits into from Oct 16, 2019

Conversation

@byCedric
Copy link
Member

byCedric commented Oct 16, 2019

Description

Fixes #830

Motivation and Context

See this comment

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@byCedric byCedric changed the title test: add failing testcase for nested parser preset factories fix(load): resolve nested parser preset factories Oct 16, 2019
@byCedric byCedric merged commit 73a7df7 into master Oct 16, 2019
3 checks passed
3 checks passed
ci/circleci: v10 Your tests passed on CircleCI!
Details
ci/circleci: v12 Your tests passed on CircleCI!
Details
ci/circleci: v8 Your tests passed on CircleCI!
Details
@byCedric byCedric deleted the fix/extended-parser-presets branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.