Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commitlint): use new read pkg syntax #888

Merged
merged 1 commit into from Jan 3, 2020

Conversation

@byCedric
Copy link
Member

byCedric commented Jan 3, 2020

Description

Fixes #887

Motivation and Context

Renovate opened a breaking PR to @alias/commitlint, which doesn't include any tests. Because of that it slipped our CI.

Usage examples

How Has This Been Tested?

Not, I'll open a separate issue for that.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@byCedric byCedric merged commit 6b3b9a9 into master Jan 3, 2020
3 checks passed
3 checks passed
ci/circleci: v10 Your tests passed on CircleCI!
Details
ci/circleci: v12 Your tests passed on CircleCI!
Details
ci/circleci: v8 Your tests passed on CircleCI!
Details
@byCedric byCedric deleted the fix/commitlint-alias-pkg-read branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.