Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.0.1 quotes commit message #621

Closed
danez opened this issue Jul 13, 2020 · 3 comments
Closed

v8.0.1 quotes commit message #621

danez opened this issue Jul 13, 2020 · 3 comments
Labels

Comments

@danez
Copy link

@danez danez commented Jul 13, 2020

Describe the bug
Version 8.0.1 does for some reason quote the commit message.

Current behavior

commit f8f0ea9bb30d759e091d1cafc034f170dea059f5
Author: Author <author@domain.com>
Date:   Mon Jul 13 11:12:25 2020 +0000
    "chore(release): 8.66.4"

Expected behavior

commit f8f0ea9bb30d759e091d1cafc034f170dea059f5
Author: Author <author@domain.com>
Date:   Mon Jul 13 11:12:25 2020 +0000
    chore(release): 8.66.4

Environment

  • standard-version version(s): 8.0.1
  • Node/npm version: 12
  • OS: linux

Additional context
Probably due to: 871201f

@JVMartin
Copy link

@JVMartin JVMartin commented Jul 13, 2020

Confirmed, this is a major issue that results in automation publishing endlessly, since the new commits do not follow semver.

image

@JVMartin
Copy link

@JVMartin JVMartin commented Jul 13, 2020

This is happening to me suddenly even on standard-version 7.1.0.

Anyone have any idea how this is happening on older versions of standard-version?

jbottigliero pushed a commit that referenced this issue Jul 14, 2020
- Authored by @runnerway – runExecFile (`child_process.execFile`) does not need additional quotes/escaping.

Closes #621, #620
@jbottigliero
Copy link
Member

@jbottigliero jbottigliero commented Jul 14, 2020

Thanks for the report - this will be included in 8.0.2 (#622).

@JVMartin - I just ran the test suite with standard-version@7.1.0 + node@12.18.2 and I'm not seeing the quotes in the commit message. If you find you're still having issues could you open a separate report with details on your environment (and maybe your releaseCommitMessageFormat configuration if you're not using the default) and I can try to help troubleshoot?

Airblader added a commit to TNG/ngqp that referenced this issue Jul 24, 2020
This avoids conventional-changelog/standard-version#621

Signed-off-by: Ingo Bürk <ingo.buerk@tngtech.com>
Airblader added a commit to TNG/ngqp that referenced this issue Jul 24, 2020
This avoids conventional-changelog/standard-version#621

Signed-off-by: Ingo Bürk <ingo.buerk@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants