Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency conventional-changelog-config-spec to v2 #352

Merged
merged 1 commit into from May 10, 2019

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented May 10, 2019

This PR contains the following updates:

Package Type Update Change References
conventional-changelog-config-spec dependencies major 1.0.0 -> 2.0.0 source

Release Notes

conventional-changelog/conventional-changelog-config-spec

v2.0.0

Compare Source


Renovate configuration

馃搮 Schedule: At any time (no schedule defined).

馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.

鈾伙笍 Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@coveralls
Copy link

@coveralls coveralls commented May 10, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling bdb8035 on renovate/conventional-changelog-config-spec-2.x into a5ac845 on master.

2 similar comments
@coveralls
Copy link

@coveralls coveralls commented May 10, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling bdb8035 on renovate/conventional-changelog-config-spec-2.x into a5ac845 on master.

@coveralls
Copy link

@coveralls coveralls commented May 10, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling bdb8035 on renovate/conventional-changelog-config-spec-2.x into a5ac845 on master.

@jbottigliero
Copy link
Member

@jbottigliero jbottigliero commented May 10, 2019

@bcoe 鈥 any thoughts on how the major version bump should impact the semver here? The "breaking" change was based on the new default for types.

@bcoe
Copy link
Member

@bcoe bcoe commented May 10, 2019

@jbottigliero in the strictest sense, this is probably breaking; but I'd feel comfortable making this a fix:

  • this brings us back to the old behavior.
  • the library was just launched.

@bcoe bcoe merged commit f586844 into master May 10, 2019
3 checks passed
@bcoe bcoe deleted the renovate/conventional-changelog-config-spec-2.x branch May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants