Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds support for header (--header) configuration based on the spec. #364

Merged
merged 2 commits into from Dec 8, 2019

Conversation

jbottigliero
Copy link
Member

@jbottigliero jbottigliero commented May 22, 2019

  • Adds shim to ensure fallback to the current default (not the value in the spec)
  • Adds warning for --changelogHeader usage.
joe:standard-version $ standard-version --dry-run --changelogHeader="Hello, World"
[standard-version]: --changelogHeader will be removed in the next major release. Use --header.

@coveralls
Copy link

@coveralls coveralls commented May 22, 2019

Coverage Status

Coverage increased (+0.005%) to 99.429% when pulling 9d51ff1 on feat-header-support into bc606f8 on master.

@jbottigliero
Copy link
Member Author

@jbottigliero jbottigliero commented Jul 24, 2019

Resolves #364

@bcoe
Copy link
Member

@bcoe bcoe commented Jul 29, 2019

@jbottigliero is the default behavior the same headers as before? just want to make sure we don't break a bunch of CHANGELOGs.

@bcoe
Copy link
Member

@bcoe bcoe commented Jul 29, 2019

(to be fair, we look for the start of a version ## 3.x.x to decide on where the last CHANGELOG entry was, so I don't think changing the header would be likely to break anyone).

@jbottigliero
Copy link
Member Author

@jbottigliero jbottigliero commented Jul 30, 2019

This shouldn't change any of the behaviors, just the sourcing... I did have to move the validation that was occurring in the .check into the actual command handler in order to allow backward compatibility and proper overriding of the flag(s).

Let me know if you think there is a specific case missing in the suite to add additional coverage.

@tommywo tommywo merged commit ba80a0c into master Dec 8, 2019
2 checks passed
@stevemao stevemao deleted the feat-header-support branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants