Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce require.resolve for the default preset #465

merged 2 commits into from Dec 6, 2019


Copy link

@merceyz merceyz commented Oct 11, 2019

In order to support Yarn 2/PnP, conventional-changelog-conventionalcommits must be declared in package.json and referenced using require.resolve.

Requires conventional-changelog/conventional-changelog#530

@merceyz merceyz changed the title feat: yarn pnp support fix: enforce require.resolve for the default preset Oct 12, 2019
@merceyz merceyz marked this pull request as ready for review October 24, 2019 15:44
Copy link
Contributor Author

merceyz commented Oct 24, 2019

Waiting for conventional-changelog/conventional-changelog#530 to be published under the latest tag

cc @tommywo

Copy link
Contributor Author

merceyz commented Nov 10, 2019

Tests are passing locally, not sure what's going on

Copy link

Coverage Status

Coverage increased (+0.0001%) to 99.897% when pulling dc7f69a on merceyz:pnp into 63300a9 on conventional-changelog:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants