Skip to content

Conversation

@merceyz
Copy link
Contributor

@merceyz merceyz commented Oct 11, 2019

In order to support Yarn 2/PnP, conventional-changelog-conventionalcommits must be declared in package.json and referenced using require.resolve.

Requires conventional-changelog/conventional-changelog#530

@merceyz merceyz changed the title feat: yarn pnp support fix: enforce require.resolve for the default preset Oct 12, 2019
@merceyz merceyz marked this pull request as ready for review October 24, 2019 15:44
@merceyz
Copy link
Contributor Author

merceyz commented Oct 24, 2019

Waiting for conventional-changelog/conventional-changelog#530 to be published under the latest tag

cc @tommywo

@merceyz
Copy link
Contributor Author

merceyz commented Nov 10, 2019

Tests are passing locally, not sure what's going on

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0001%) to 99.897% when pulling dc7f69a on merceyz:pnp into 63300a9 on conventional-changelog:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants