Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --lerna-package flag used to extract tags in case of lerna repo #503

Conversation

@micaelmbagira
Copy link
Contributor

@micaelmbagira micaelmbagira commented Dec 13, 2019

The package conventional-recommended-bump allows a lernaPackage option. See conventional-recommended-bump/index.js#L64-L65

This PR exposes this flag in the standard-version options and pass it along to conventional-recommended-bump

@coveralls
Copy link

@coveralls coveralls commented Dec 13, 2019

Coverage Status

Coverage remained the same at 99.429% when pulling d9465cf on micaelmbagira:feat/add-lerna-package-option into 2f04ac8 on conventional-changelog:master.

@micaelmbagira
Copy link
Contributor Author

@micaelmbagira micaelmbagira commented Jan 12, 2020

@bcoe @jbottigliero What do you think?

@palash2601
Copy link

@palash2601 palash2601 commented Apr 30, 2021

Hello,

We are looking forward to use standard-version for our monorepo. Any plans to merge this PR?

@bcoe
Copy link
Member

@bcoe bcoe commented May 4, 2021

@micaelmbagira apologies for dropping this PR on the floor for so long, I appreciate the contribution.

@palash2601 I see no reason not to land this as soon as tests pass 👍

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented May 4, 2021

Codecov Report

Merging #503 (c9b03a0) into master (3d341c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #503   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          24       24           
  Lines        1067     1067           
=======================================
  Hits         1043     1043           
  Misses         24       24           
Impacted Files Coverage Δ
command.js 84.61% <ø> (ø)
lib/lifecycles/bump.js 98.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d341c2...c9b03a0. Read the comment docs.

bcoe
bcoe approved these changes May 4, 2021
@bcoe bcoe merged commit f579ff0 into conventional-changelog:master May 4, 2021
6 checks passed
@micaelmbagira micaelmbagira deleted the feat/add-lerna-package-option branch May 4, 2021
@gaurav5430
Copy link

@gaurav5430 gaurav5430 commented Jul 6, 2021

How is this supposed to be used with a lerna setup?

Should it replace the conventional-commits setup that lerna provides by default ?

@kkazala
Copy link

@kkazala kkazala commented Jul 15, 2021

Is there support for lerna independent mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants