Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(windows): skip mock-git tests for Windows #616

Merged
merged 3 commits into from Jul 12, 2020
Merged

test(windows): skip mock-git tests for Windows #616

merged 3 commits into from Jul 12, 2020

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Jul 12, 2020

The mock-git tests now exhibit a variety of odd behaviors on Windows:

  • an error is captured and output regarding line endings.
  • the commands ultimately passed to the git bin are in a different format (this is probably related to the switch to execFile.

tldr; let's turn off these tests on Windows for now.

@bcoe bcoe changed the title [DO NOT LAND] chore: debugging windows failures test(windows): skip mock-git tests for Windows Jul 12, 2020
@bcoe bcoe merged commit da84ec4 into master Jul 12, 2020
5 checks passed
@bcoe bcoe deleted the debug-windows branch Jul 12, 2020
@bcoe
Copy link
Member Author

@bcoe bcoe commented Jul 12, 2020

cc: @jbottigliero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant