Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom updater as object as well as path #630

Merged
merged 2 commits into from Sep 11, 2020

Conversation

@eemeli
Copy link
Contributor

@eemeli eemeli commented Jul 23, 2020

This adds support for defining the updater directly in a JS config file, rather than requiring it to be passed in as a path to be required.

Fixes #631

@eemeli
Copy link
Contributor Author

@eemeli eemeli commented Jul 23, 2020

It looks like the force-push didn't trigger the GH action? That should have fixed the linter complaints.

@eemeli
Copy link
Contributor Author

@eemeli eemeli commented Sep 9, 2020

Rebased on latest master, with test following new mock style.

@brettdh
Copy link

@brettdh brettdh commented Sep 11, 2020

I also ran into this issue today, in the context of expo-community/standard-version-expo#17.

In the README.md in that diff, I wrote require.resolve where I meant require, but the idea was to import a function from the module and call it, returning a { readVersion, writeVersion } object, as a way of passing extra parameters to the updater.

@bcoe bcoe changed the title Support custom updater as object as well as path feat: support custom updater as object as well as path Sep 11, 2020
bcoe
bcoe approved these changes Sep 11, 2020
@bcoe bcoe merged commit 55bbde8 into conventional-changelog:master Sep 11, 2020
4 checks passed
@eemeli eemeli deleted the fix-updater branch Sep 12, 2020
@brettdh
Copy link

@brettdh brettdh commented Sep 27, 2020

Glad to see this merged. It's been a couple weeks since #662 was opened; when do you think we'll see 9.1.0 released? I'd like to start building on this functionality in expo-community/standard-version-expo#17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants