Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lang): Chinese translation update (v1.0.0-beta2 & beta3) #124

Merged

Conversation

@seognil
Copy link
Contributor

seognil commented Feb 5, 2019

Mainly two things

  • fix little English version error
  • update Chinese version text and config
@@ -31,7 +31,7 @@ consumers of your library:
with [`MINOR`](http://semver.org/#summary) in semantic versioning).
1. **BREAKING CHANGE:** a commit that has the text `BREAKING CHANGE:` at the beginning of its optional body or footer section introduces a breaking API change (correlating with [`MAJOR`](http://semver.org/#summary) in semantic versioning). A breaking change can be
part of commits of any _type_. e.g., a `fix:`, `feat:` & `chore:` types would all be valid, in addition to any other _type_.
1. Others: commit _types_ other than `fix:` and `feat:` are allowed, for example [commitlint-config-conventional](https://github.com/marionebl/commitlint/tree/master/%40commitlint/config-conventional) (based on the [the Angular convention](https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#-commit-message-guidelines)) recommends `chore:`, `docs:`, `style:`, `refactor:`, `perf:`, `test:`, and others. We also recommend `improvement` for commits that improve a current implementation without adding a new feature or fixing a bug. Notice these types are not mandated by the conventional commits specification, and have no implicit effect in semantic versioning (unless they include a BREAKING CHANGE, which is NOT recommended).

This comment has been minimized.

Copy link
@damianopetrungaro

damianopetrungaro Feb 5, 2019

Member

These changes should not be there 😄

This comment has been minimized.

Copy link
@seognil

seognil Feb 5, 2019

Author Contributor

[commitlint-config-conventional](https://github.com/marionebl/commitlint/tree/master/%40commitlint/config-conventional)
is a dead link now, that repo has moved to a new place
I just updated the link.

This comment has been minimized.

Copy link
@damianopetrungaro

damianopetrungaro Feb 5, 2019

Member

So let's fix it in another PR (or at least change the name of the PR)

This comment has been minimized.

Copy link
@seognil

seognil Feb 5, 2019

Author Contributor

Oh yeah, you are right, thanks
(never thought that before, sorry... 😥)
I'll make a new commit to (manually) reverse these changes and a new PR soon

This comment has been minimized.

Copy link
@seognil

seognil Feb 6, 2019

Author Contributor

@damianopetrungaro
I'm thinking should I rework my branch to only output fewer cleaner commits (is that ok for the github review system?)
or close this PR and make a brand new one
or is current commit history for this PR acceptable

@@ -132,7 +132,7 @@ It discourages moving fast in a disorganized way. It helps you be able to move f

### Might Conventional Commits lead developers to limit the type of commits they make because they'll be thinking in the types provided?

Conventional Commits encourages us to make more of certain types of commits such as fixes. Other than that, the flexibility of Conventional Commits allows your team to come up with their own types and change those types over time.

This comment has been minimized.

Copy link
@damianopetrungaro

damianopetrungaro Feb 5, 2019

Member

These changes should not be there 😄

This comment has been minimized.

Copy link
@seognil

seognil Feb 5, 2019

Author Contributor

add backquote to the word fixes
(I guess it's supposed to be?)

@seognil seognil changed the title Zh update Chinese update (v1.0.0-beta2 & beta3) Feb 5, 2019
@seognil seognil changed the title Chinese update (v1.0.0-beta2 & beta3) feat(lang): Chinese translation update (v1.0.0-beta2 & beta3) Feb 6, 2019
@stevemao

This comment has been minimized.

Copy link
Member

stevemao commented Feb 7, 2019

cc @doodlewind

@doodlewind

This comment has been minimized.

Copy link
Contributor

doodlewind commented Feb 7, 2019

LGTM! Happy Chinese New Year!

@damianopetrungaro damianopetrungaro merged commit bd6f332 into conventional-commits:master Feb 8, 2019
1 check passed
1 check passed
netlify/tender-babbage-1fbb34/deploy-preview Deploy preview ready!
Details
@damianopetrungaro

This comment has been minimized.

Copy link
Member

damianopetrungaro commented Feb 8, 2019

Ty @seognil for the huge effort and @doodlewind for the native review :D

@seognil seognil deleted the seognil-contributor:zh-update branch Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.