Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: (for en beta2&3 only) dead links, some text errors. #126

Merged
merged 2 commits into from Feb 8, 2019
Merged

Conversation

seognil
Copy link
Contributor

@seognil seognil commented Feb 5, 2019

No description provided.

Copy link
Member

@stevemao stevemao left a comment

Looks good in general! Thanks

@@ -132,7 +132,7 @@ It discourages moving fast in a disorganized way. It helps you be able to move f

### Might Conventional Commits lead developers to limit the type of commits they make because they'll be thinking in the types provided?

Conventional Commits encourages us to make more of certain types of commits such as fixes. Other than that, the flexibility of Conventional Commits allows your team to come up with their own types and change those types over time.
Conventional Commits encourages us to make more of certain types of commits such as `fixes`. Other than that, the flexibility of Conventional Commits allows your team to come up with their own types and change those types over time.
Copy link
Member

@stevemao stevemao Feb 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be fix?

Copy link
Contributor Author

@seognil seognil Feb 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's still fixes because the context said more types and fix has already shown up above

Copy link
Member

@damianopetrungaro damianopetrungaro Feb 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm dunno about that one, you may open an issue and let's discuss it all together.
If you remove this one we can merge the dead links fix 👍

Copy link
Member

@stevemao stevemao Feb 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think the original sentence is wrong. Maybe it should say

Conventional Commits encourages us to make more of certain types of commits such as improvement or cleanup.

Copy link
Contributor Author

@seognil seognil Feb 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

Copy link
Member

@stevemao stevemao left a comment

Thanks

@damianopetrungaro damianopetrungaro merged commit 6774a3f into conventional-commits:master Feb 8, 2019
1 check passed
@seognil seognil deleted the en-fixes branch Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants