Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release version 1.0.0-beta.4 of spec #141

Merged
merged 3 commits into from Apr 16, 2019
Merged

feat: release version 1.0.0-beta.4 of spec #141

merged 3 commits into from Apr 16, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Apr 10, 2019

having reworked our wording to be more inline with RFC-2119 and added support for ! (and the project having existed for a few years now) I think it's about high time that we drop the beta label and move to v1.0.0 of the spec 馃嵃

Copy link
Member

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殺

@damianopetrungaro
Copy link
Member

My only concern is about the ! introduced recently.
See that is still not mandatory I was wondering if the tools were going to support it or not.

I am fine to release a non-beta version, but I would rather wait some time to see if the new signal is used, and so discuss to make it mandatory, introducing no BC with a final release :)

My 2 cents :)

@apetro
Copy link
Contributor

apetro commented Apr 16, 2019

I agree with @damianopetrungaro : In general would be wise to release a beta of the spec that is a candidate for being the 1.0.0 spec, before releasing that 1.0.0, to see what reaction the beta gets. In specific, it's an opportunity to get feedback on the ! spec feature and another chance to discover that it should be REQUIRED, before 1.0.0, since making it REQUIRED later would be a breaking change. :)

@bcoe bcoe changed the title feat: release version 1.0.0 of spec feat: release version 1.0.0-beta.4 of spec Apr 16, 2019
@bcoe bcoe merged commit 44ec849 into master Apr 16, 2019
@bcoe bcoe deleted the v1 branch April 16, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants