Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing in MUC shows "Typing from another device" #1026

Closed
ge0rg opened this issue Feb 28, 2018 · 8 comments

Comments

@ge0rg
Copy link

commented Feb 28, 2018

When I'm in a MUC with full-screen converse (3.3.3), and I start typing, I see "Typing from another device" displayed, despite not being active in any other client at the same time. Is it possible that this was introduced with #802, and that the internal logic sees the MUC reflection as "I'm typing" without checking whether this was initially sent by converse?

Maybe this asks for a complete block of self-typing in MUCs, or at least tracking of our own CSN message IDs so we can ignore them?

@jcbrand

This comment has been minimized.

Copy link
Member

commented Mar 2, 2018

What server are you using? Is there a MUC where I can test this? I haven't seen this myself yet.

The code naively assumes any incoming CSN messages are from other devices.

@ge0rg

This comment has been minimized.

Copy link
Author

commented Mar 2, 2018

I've tested it with a self-hosted 3.3.3 on the prosody MUC (prosody@conference.prosody.im) and on another MUC running on chat.yax.im.

@jcbrand

This comment has been minimized.

Copy link
Member

commented Mar 3, 2018

I just tested with the Prosody MUC and can confirm that I received <composing> and <paused> CSN messages (by looking in the dev console), but I did NOT get any "Typing from another device" notifications, I didn't get any CSN notifications at all.

I remember there already being a check for message IDs to filter out dupes, so this makes sense to me.

Are you able to replicate reliably?

@Zash

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2018

I too see this, using mod_conversejs on my development Prosody.

@guusdk

This comment has been minimized.

Copy link
Member

commented Mar 29, 2018

I'm seeing the same thing in an Openfire-based MUC.

@jcbrand jcbrand added this to the 4.0.0 milestone Apr 6, 2018

@jcbrand jcbrand closed this in 7303e96 Apr 10, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented Apr 10, 2018

I've disabled the typing from another device CSN messages. To keep this feature we would need to keep track of the ids of these notifications which seems like unnecessary complexity given the negligible value of this feature.

@jcbrand

This comment has been minimized.

Copy link
Member

commented Apr 11, 2018

Reopening since I realised we can check whether the incoming CSN is a carbon copy and show the notification based on that.

@jcbrand jcbrand reopened this Apr 11, 2018

@ge0rg

This comment has been minimized.

Copy link
Author

commented Apr 11, 2018

You won't get Carbons for 'groupchat' messages, only for MUC-PMs and for direct messages.

@jcbrand jcbrand closed this in aacfe3b Apr 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.