Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse multiple join/leave messages into one. #1062

Closed
Zash opened this issue Apr 7, 2018 · 2 comments

Comments

@Zash
Copy link
Contributor

commented Apr 7, 2018

A moderately sized room that is quiet for some time tends to collect a number of join and leave messages. These aren't all that interesting, so having them take up less UI space would be nice. One exception I can think of would be the part message of someone who was recently active / sent messages.

An example of this can be found in Swift, where such idle comings and goings would show up something like:

Alice, Bob and Steve joined the room. Eve and Carlos left the room. Trent left then returned to the room.

@jcbrand jcbrand added the Feature label Apr 10, 2018

@jcbrand jcbrand changed the title Join and part messages are boring Collapse multiple join/leave messages into one. Apr 10, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented Sep 10, 2018

A leave notification, followed later by a join notification (with no chat messages in between, but perhaps with other join/leave notifications from other users) can be squashed.

However we don't want to do the reverse, because it might be relevant to know that someone popped in to check the MUC history.

@jcbrand jcbrand closed this in 7270abb Oct 13, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented Oct 13, 2018

I think I've done enough here to close this issue, even though I haven't done exactly what you asked for.

To collapse all leave/join messages into one seems like more work than it's worth, especially given the opportunity cost of not getting to other tasks/features.

What I've done now:

  • If a user joins and leaves without any chat messages appearing in between, then the notifications are combined and the resulting notification fades out after 5 seconds.
  • The same applies to a leave and then join.
  • I've made the join/leave messages 20% smaller and reduced their padding by 50%.

I believe this should go a long way to avoid join/leave clutter and should hopefully appease most.
Otherwise we can always re-open or create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.