Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show members in members-only rooms #1094

Closed
ChaosKid42 opened this issue May 4, 2018 · 13 comments

Comments

@ChaosKid42
Copy link
Contributor

commented May 4, 2018

converse.js shows only occupants in a muc room (i.e. only those users who are actually "online" in a muc). I feel this is completely OK for an open room. In case of a members-only room however it feels strange that the administrator/owner who adds members to his room has absolutely no feedback (i.e. there is no list of current members).

Therefore I suggest that converse.js shows also those members of a members-only room who are currently not visiting the room.

@jcbrand jcbrand added the Feature label May 5, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented May 5, 2018

Agreed, suggestions for how the UI should look would be welcome :)

@ChaosKid42

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2018

I would simply show those users without any status circle and using a color of lightgrey. See example for user ChaosKid42:

screenshot-2018-5-5 converse js 1

@jcbrand jcbrand closed this in 859bc06 May 9, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented May 9, 2018

Done. This is done for all rooms, not only members-only rooms (since any room can have a members list).

@jcbrand jcbrand added this to the 4.0.0 milestone May 9, 2018

@ChaosKid42

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2018

Thank you for imlementing this! It improves managing a members-only room very much.

However I have one suggestion: If you add a new member to a room using the command "/member " the occupants list is not updated. You have to leave and rejoin the room to see an updated list. Same happens, if you update the list of members using another client.

It would be very nice if these changes would automatically lead to an update of the occupants list.

@jcbrand jcbrand reopened this May 10, 2018

jcbrand added a commit that referenced this issue May 10, 2018

updates #1094
Refetch the members lists when adding a new member via invite

jcbrand added a commit that referenced this issue May 10, 2018

updates #1094
Update the occupants list when occupants are added/removed from the
member lists.
@jcbrand

This comment has been minimized.

Copy link
Member

commented May 10, 2018

Good point, should be better now :)

@jcbrand

This comment has been minimized.

Copy link
Member

commented May 10, 2018

Please check and close if appropriate.

@jcbrand jcbrand closed this May 10, 2018

@jcbrand jcbrand reopened this May 10, 2018

@ChaosKid42

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2018

I'd like to test but currently I'm not able to run it:

FATAL: initialize@http://localhost:8000/dist/converse.js:54439:7
initializePlugin@http://localhost:8000/dist/converse.js:42796:21
loadPluginDependencies/<@http://localhost:8000/dist/converse.js:42739:21
arrayEach@http://localhost:8000/dist/converse.js:4442:11
forEach@http://localhost:8000/dist/converse.js:13264:14
loadPluginDependencies@http://localhost:8000/dist/converse.js:42732:13
initializePlugin@http://localhost:8000/dist/converse.js:42792:21
arrayEach@http://localhost:8000/dist/converse.js:4442:11
forEach@http://localhost:8000/dist/converse.js:13264:14
initializePlugins@http://localhost:8000/dist/converse.js:42829:13
_converse.initialize/this.initPlugins@http://localhost:8000/dist/converse.js:44516:7
finishInitialization@http://localhost:8000/dist/converse.js:44536:7
tryCatch@http://localhost:8000/dist/converse.js:3132:12
invokeCallback@http://localhost:8000/dist/converse.js:3147:13
publish@http://localhost:8000/dist/converse.js:3121:7
flush@http://localhost:8000/dist/converse.js:2851:5
@jcbrand

This comment has been minimized.

Copy link
Member

commented May 11, 2018

Sorry, should be fixed now.

@ChaosKid42

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2018

Works like a charm. Thank you!

@ChaosKid42 ChaosKid42 closed this May 11, 2018

@ChaosKid42

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2018

I reopened the issue because I found another bug :-(

A member (not the user currently using converse.js) that is leaving a room is not changed from "online" to "offline" status but removed from the list of occupants entirely. After the user of converse.js leaves and rejoins the room the list of occupants is updated and the member is correctly shown as offline member.

The list of occupants should be updated correctly. The leaving user ist not to be removed from the list but its status ist to be changed to "offline".

@ChaosKid42 ChaosKid42 reopened this May 12, 2018

jcbrand added a commit that referenced this issue May 23, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented May 23, 2018

@ChaosKid42 That should now be fixed as well.

Ideally I would add tests to check that this is the case, but I currently don't have time for this.

jcbrand added a commit that referenced this issue May 24, 2018

@ChaosKid42

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2018

Perfect. Thanks!

@ChaosKid42 ChaosKid42 closed this May 24, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented May 24, 2018

Super, I managed to add some tests today as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.