Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Up arrow edits previous message, down arrow erases the currently writing message #1142
This applies to computers with a keyboards, this does not apply mobile/tablets.
I have two bug scenarios. I believe they are related, I can still split this bug report.
In both cases, I would expect that my temporary message should be "saved" for editing in the input field.
Fixed in 19f6bce, but in a different way then suggested.
Here's the commit message:
Up and down arrows only serve as message correction shortcuts if the textarea is empty.
This is based on user-feedback and is also how Slack handles these shortcuts.
Great, thanks a lot! :)
Unfortunately, it does not seem to work on my setup:
Steps to reproduce:
@Nyco The up/down arrow now no longer works for editing messages if you have text in the textarea. So based on your latest feedback, it sounds to me like you didn't actually have this fix applied when testing.
There is still the issue where a user clicks the pencil icon to edit a message and thereby overwrites the textarea. I think for this we can just add a confirmation dialog.
To save the previous textarea value and then revert back to it could be quite confusing to users and also complicates the code in a way that doesn't appear necessary.