Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up arrow edits previous message, down arrow erases the currently writing message #1142

Closed
Nyco opened this issue Jul 27, 2018 · 4 comments

Comments

@Nyco
Copy link
Member

commented Jul 27, 2018

This applies to computers with a keyboards, this does not apply mobile/tablets.

I have two bug scenarios. I believe they are related, I can still split this bug report.

  1. Up and back down:
  • I write a message in input field
  • I hit the up arrow n times for whatever reason
  • I hit the down arrow again, n times as well, my message I was writing is erased/blank
  1. Down and back up:
  • I write a message in input field
  • I hit the down arrow for whatever reason
  • I hit the up arrow again, my message I was writing is erased/blank

In both cases, I would expect that my temporary message should be "saved" for editing in the input field.

@jcbrand jcbrand added the bug label Jul 27, 2018

@jcbrand jcbrand added this to the 4.0.0 milestone Jul 27, 2018

@jcbrand jcbrand modified the milestones: 4.0.0, 4.0.1 Sep 7, 2018

@jcbrand jcbrand modified the milestones: 4.0.1, 4.0.2 Sep 22, 2018

@jcbrand jcbrand modified the milestones: 4.0.2, 4.0.3 Oct 3, 2018

@jcbrand jcbrand removed this from the 4.0.3 milestone Oct 11, 2018

@Nyco Nyco added the UX label Nov 27, 2018

jcbrand added a commit that referenced this issue Jun 17, 2019
Message correction improvements. Updates #1142
Up and down arrows only serve as message correction shortcuts if the
textarea is empty.

This means that:

- Up arrow doesn't start correction of previous message if we're currently writing a message
- Down arrow doesn't erase currently written message

This is based on user-feedback and is also how Slack handles these
shortcuts.
@jcbrand

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Fixed in 19f6bce, but in a different way then suggested.

Here's the commit message:

Up and down arrows only serve as message correction shortcuts if the textarea is empty.
This means that:

  • Up arrow doesn't start correction of previous message if we're currently writing a message
  • Down arrow doesn't erase currently written message

This is based on user-feedback and is also how Slack handles these shortcuts.

@jcbrand jcbrand closed this Jun 17, 2019

@Nyco

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

Great, thanks a lot! :)

Unfortunately, it does not seem to work on my setup:

  • macOS latest
  • Firefox latest, Chrome latest, Opera latest
  • Converse latest commit

Steps to reproduce:
GIVEN I have logged in successfully
AND I have sent a message (groupchat or one-to-one)
AND I have a new message typed in but not sent yet
AND I am navigating up/down arrow in my sent messages
WHEN I hit the bottom of the list (my currently typing message)
THEN it should be displayed in the input field textarea ready to edit again (and send later)
BUT the input field textarea is fully blank, empty

@Nyco Nyco reopened this Jun 17, 2019

@jcbrand

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Please check again... you should not be able to edit older messages at all if you're currently drafting a new message.

Also, please read the commit message, the fix doesn't behave the way you're expecting.

@jcbrand

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

@Nyco The up/down arrow now no longer works for editing messages if you have text in the textarea. So based on your latest feedback, it sounds to me like you didn't actually have this fix applied when testing.

There is still the issue where a user clicks the pencil icon to edit a message and thereby overwrites the textarea. I think for this we can just add a confirmation dialog.

To save the previous textarea value and then revert back to it could be quite confusing to users and also complicates the code in a way that doesn't appear necessary.

@jcbrand jcbrand closed this in 9750dcf Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.