Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration: "allow_non_roster_messaging: true" -> incomplete chat window #1221

Closed
MotoGP-Fan opened this issue Sep 24, 2018 · 8 comments

Comments

@MotoGP-Fan
Copy link

commented Sep 24, 2018

Converse release: 4.0.1
Prosody 0.10.2 on Debian 9

If "allow_non_roster_messaging" is set to "true" (default=false) the chat window will not appear in usual style ->text input not possible.
If you want to test this by yourself don't forget to clear browser cache and reload site after changing the configuration option. See pic:

webchat_nok_pixel

@sicherha

This comment has been minimized.

Copy link

commented Sep 25, 2018

I can reproduce this behaviour: the input area goes missing when OMEMO support is enabled (i.e. when libsignal-protocol.js is loaded) and allow_non_roster_messaging is true. With either of the two disabled, the input widget re-appears.

@jcbrand jcbrand added the bug label Sep 26, 2018

@jcbrand jcbrand added this to the 4.0.2 milestone Sep 26, 2018

@jcbrand jcbrand modified the milestones: 4.0.2, 4.0.3 Oct 3, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented Oct 5, 2018

@MotoGP-Fan and @sicherha: I'm not able to reproduce this bug. Can you please check again whether it's fixed with the 4.0.2 release? Make sure the browser's cache is cleared.

@jcbrand jcbrand closed this Oct 5, 2018

@sicherha

This comment has been minimized.

Copy link

commented Oct 10, 2018

I am still affected by this issue with 4.0.2, but so far I haven't been able to pinpoint it further. It occurs for many contacts in my roster, but not for all of them; there is no discernible scheme.

Whenever I encounter the problem, the following three conditions coincide:

  1. The chat-window frame is amber, not green.
  2. The input widget is missing.
  3. Clicking on the business-card icon has no effect; the user-info overlay does not pop up.

Cleaning the cache or the site's web storage did not help. No errors are shown in the web-developer console.

@jcbrand

This comment has been minimized.

Copy link
Member

commented Oct 10, 2018

@sicherha Please set debug: true when calling converse.initialize, or use https://conversejs.org/fullscreen_debug.html

Then in your browser console, enable verbose logging. Then reproduce the problem, copy the entire log output and paste it here.

Then I can try and see what the problem is.

@jcbrand jcbrand reopened this Oct 10, 2018

@sicherha

This comment has been minimized.

Copy link

commented Oct 10, 2018

Log sent via email.

jcbrand added a commit that referenced this issue Oct 10, 2018

Avoid creating a headlines box...
if we don't have anything to show inside it.

Updates #1221

jcbrand added a commit that referenced this issue Oct 10, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented Oct 10, 2018

@sicherha I think I found and fixed the bug. You were using allow_non_contact_requests: true right? This caused an orange headlines box to be created for an OMEMO headline message which in turn prevented a normal chat to be created.

Are you using the CDN or do you have a dev environment set up for Converse?

@sicherha

This comment has been minimized.

Copy link

commented Oct 10, 2018

Yes, I was using allow_non_contact_requests: true. Our deployment is hosted locally and doesn't make use of the CDN.

I can confirm that your patch appears to fix the issue for me. Thanks for the quick and competent response! 👍

@jcbrand jcbrand closed this Oct 11, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

Cool, thanks for the confirmation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.