Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect text in tooltipo of top-right bookmark button #1252

Closed
guusdk opened this issue Oct 22, 2018 · 0 comments

Comments

@guusdk
Copy link
Member

commented Oct 22, 2018

When joined a bookmarked multi-user chat room, the tooltip of the 'bookmark' button in Converse 4.0.2 reads "Bookmark this groupchat". As the groupchat is already bookmarked, the tooltip should probably read something like "Unbookmark this groupchat."

Of interest: after applying the bookmark, the icon does change (from 'unbookmarked' to 'bookmarked' state). Als, the behavior is correct (clicking the button will unbookmark the room). The problem seems to be isolated to the tool tip text.

@jcbrand jcbrand added the bug label Oct 25, 2018

Ppjet6 added a commit to Ppjet6/converse.js that referenced this issue Oct 25, 2018

Update CHANGES.md for conversejs#1252
Signed-off-by: Maxime “pep” Buquet <pep@bouah.net>

@jcbrand jcbrand closed this in 6f45733 Oct 26, 2018

jcbrand added a commit that referenced this issue Oct 26, 2018

Merge pull request #1271 from Ppjet6/issue-1252-bookmark-title
Fix #1252, incorrect bookmark icon title

@jcbrand jcbrand added this to the 4.0.4 milestone Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.