Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back "me " and "" them " class back to differentiate between incoming message and outgoing message. #1288

Closed
golangbu opened this issue Oct 31, 2018 · 6 comments

Comments

@golangbu
Copy link
Contributor

commented Oct 31, 2018

Can we have some difference between incoming message and outgoing message.May be different colour message bubble or left side send message and right side receive message.

@martinmix

This comment has been minimized.

Copy link

commented Oct 31, 2018

WOW. nice idea.

@Nyco

This comment has been minimized.

Copy link
Member

commented Oct 31, 2018

Quick investigation:

  • Coloring me/them: it seems that modern team chats don't do that anymore, but only smartphone interpersonal chat keep on doing that
  • Chat bubbles have completely disappeared from team chats

Thats seems to be some code to maintain and test for very few value.

@golangbu

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2018

Actually I am asking for to add back "me " and "" them " class back .
If somebody like bubble they can change in css class.Right now it is not possible to differentiate the sender and receiver class because it use one class for both sender and receiver.

@jcbrand jcbrand added this to the 4.0.5 milestone Nov 15, 2018

@jcbrand jcbrand closed this in 7e24019 Nov 15, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented Nov 15, 2018

@golangbu There are now the classes chat-msg__me and chat-msg__them to help you differentiate between incoming and outgoing messages.

@golangbu

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2018

@jcbrand should I make a pull request for adding chat bubble and make it as optional parameter?
If you do not want chat bubble then I will work on some other issues.
I guess most people not want it

@jcbrand

This comment has been minimized.

Copy link
Member

commented Nov 16, 2018

@golangbu You're welcome to make another theme with chat bubbles, in the same way that @linkmauve did in #1167

In your case, that would simply mean adding a new class and variables in sass/_variables.scss

Like here: https://github.com/conversejs/converse.js/blob/master/sass/_variables.scss#L176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.