Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False mentions positives in URLs and Email addresses #1327

Closed
jcbrand opened this issue Nov 15, 2018 · 3 comments

Comments

Projects
None yet
2 participants

@jcbrand jcbrand added the bug label Nov 15, 2018

@darnuria

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

Hi @jcbrand , can I work on this? @linkmauve can mentor me on this.

darnuria added a commit to darnuria/converse.js that referenced this issue Mar 4, 2019

WIP attempt to fix issue conversejs#1327
Before the function `extractReference` in
`/src/headless/converse-muc.js` matched url and email.

Fix: conversejs#1327

darnuria added a commit to darnuria/converse.js that referenced this issue Mar 4, 2019

WIP attempt to fix issue conversejs#1327
Before the function `extractReference` in
`/src/headless/converse-muc.js` matched url and email.

Fix: conversejs#1327
@jcbrand

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

@darnuria: yes please!

@darnuria

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@jcbrand I have no news from @linkmauve, I will open the pull-request and ask for review! :)

darnuria added a commit to darnuria/converse.js that referenced this issue Mar 6, 2019

WIP attempt to fix issue conversejs#1327
Before the function `extractReference` in
`/src/headless/converse-muc.js` matched url and email.

Fix: conversejs#1327

@darnuria darnuria referenced this issue Mar 6, 2019

Merged

WIP attempt to fix issue #1327 #1482

3 of 3 tasks complete

darnuria added a commit to darnuria/converse.js that referenced this issue Mar 6, 2019

WIP attempt to fix issue conversejs#1327
Before the function `extractReference` in
`/src/headless/converse-muc.js` matched url and email.

Fix: conversejs#1327

darnuria added a commit to darnuria/converse.js that referenced this issue Mar 6, 2019

WIP attempt to fix issue conversejs#1327
Before the function `extractReference` in
`/src/headless/converse-muc.js` matched url and email.

Fix: conversejs#1327

darnuria added a commit to darnuria/converse.js that referenced this issue Mar 6, 2019

WIP attempt to fix issue conversejs#1327
Before the function `extractReference` in
`/src/headless/converse-muc.js` matched url and email.

Fix: conversejs#1327

darnuria added a commit to darnuria/converse.js that referenced this issue Mar 6, 2019

WIP attempt to fix issue conversejs#1327
Before the function `extractReference` in
`/src/headless/converse-muc.js` matched url and email.

Fix: conversejs#1327

darnuria added a commit to darnuria/converse.js that referenced this issue Mar 7, 2019

Fix conversejs#1327: Refusing url and email as mentions
Before the function `extractReference` in
`/src/headless/converse-muc.js` matched url and email.

Fix: conversejs#1327

@jcbrand jcbrand closed this in #1482 Mar 7, 2019

jcbrand added a commit that referenced this issue Mar 7, 2019

Fix #1327: Refusing url and email as mentions
Before the function `extractReference` in
`/src/headless/converse-muc.js` matched url and email.

Fix: #1327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.