Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force avatar refetch when receiving vcard-temp:x:update #1334

Closed
Lynesth opened this issue Nov 20, 2018 · 0 comments

Comments

@Lynesth
Copy link
Contributor

commented Nov 20, 2018

It seems that converse will only fetch avatar for a specific user only if it didn't already do so on the same day.

When users change avatar and send a presence stanza with vcard-temp:x:update, I think we should force the update on converse side.

Edit: Just to add that it should - I'm not saying I know all the underlyings things going on in converse - be as easy as adding a true in the onAvatarChanged function of the model

if (hash && vcard.get('image_hash') !== hash) {
    _converse.api.vcard.update(vcard, true); // <- here
}

Lynesth added a commit to Lynesth/converse.js that referenced this issue Jan 5, 2019

jcbrand added a commit that referenced this issue Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.