Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Message Delivery Receipts not working because of the message "type" attribute #1353
Hi, it's the first issue I open so please understand if I do not follow the exact guidelines.
While testing the new Message Delivery Receipts feature you have merged into master recently (few days ago), I have noticed that there is a minor and strange bug which makes the delivery receipts not working.
Cause: The message handler registered in converse-chatboxes.js at line 627 is filtering the stanzas by their type=chat attribute. Code:
But the delivery receipt stanza sending code does not add the type=chat attribute to the message stanza, hence making the message handler miss the delivery receipts.
As far as I can tell, it is indeed a bug - maybe I have missed something, but while testing delivery receipts, I noticed they were not working and the cause was this attribute missing. Checking the XEP-0184 specs, I do not see any type=chat attribute in the guidelines, so probably the message handler needs to be changed instead of adding that attribute. I would happily do it, but I am afraid I do not have the required experience with this to make sure the code changes will work properly.
Thanks @catalincic, your bug report is quite clear and detailed.
Maybe @ChaosKid42 wants to take a look, otherwise I'll do so later in the month.
I think the solution is to update