Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make triangle icon usable #1356

Closed
deleolajide opened this issue Nov 29, 2018 · 0 comments

Comments

@deleolajide
Copy link
Member

commented Nov 29, 2018

The grouping triangle icon should be clickable and just as functional as the text, there is a general expectation that the icons are used to control, expand and collapse the lists.

First reported at igniterealtime/Pade#58

When triangle is clicked with current version 4.0.5, you will get in the Chrome DevTools console:

Uncaught TypeError: Cannot read property 'classList' of null
    at child.toggleRoomsList (converse.js:58793)
    at wrapper (converse.js:13440)
    at HTMLDivElement.handler (converse.js:1005)
  | toggleRoomsList | @ | converse.js:58793
  | wrapper | @ | converse.js:13440
  | handler | @ | converse.js:1005

@jcbrand jcbrand added bug UX labels Nov 29, 2018

@jcbrand jcbrand added this to the 4.0.6 milestone Nov 29, 2018

@jcbrand jcbrand modified the milestones: 4.0.6, 4.0.7 Dec 10, 2018

@jcbrand jcbrand closed this in 7d74319 Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.