Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of message with subject and body/thread #1369

Closed
Zash opened this issue Dec 8, 2018 · 0 comments

Comments

@Zash
Copy link
Contributor

commented Dec 8, 2018

Per the holy text:

The subject is changed by sending a message of type "groupchat" to the <room@service>, where the <message/> MUST contain a <subject/> element that specifies the new subject but MUST NOT contain a <body/> element (or a <thread/> element). In accordance with the core definition of XMPP, other child elements are allowed (although the entity that receives them might ignore them).

Note: A message with a <subject/> and a <body/> or a <subject/> and a <thread/> is a legitimate message, but it SHALL NOT be interpreted as a subject change.
This is a topic change:

<message type="groupchat">
  <subject>Fire Burn and Cauldron Bubble!</subject>
</message>

This is not a topic change:

<message type="groupchat">
  <subject>Did you know</subject>
  <body>Normal groupchat messages can have a subject line</body>
</message>

Neither is this:

<message type="groupchat">
  <subject>Threads, how do they work?</subject>
  <thread>eb07d7b1-7b6c-4067-a540-cbd0c29285cd</thread>
</message>

Converse.js v4.0.5 treats both these cases as subject changes.

@jcbrand jcbrand added the bug label Dec 10, 2018

@jcbrand jcbrand modified the milestone: 4.0.7 Dec 30, 2018

@jcbrand jcbrand added this to the 4.1.1 milestone Jan 25, 2019

jcbrand added a commit that referenced this issue Jan 28, 2019

Refactor out `createMessage`.
Changes:

* Avoids leaky abstraction of MUC code into converse-chatboxes
* Avoid creating unnecessary message objects (e.g. without <body)
* Add fix for #1369.
* Rename spec/chatroom.js to spec/muc.js

@jcbrand jcbrand closed this in d97deae Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.