Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
http upload not working in version 4.1.0 if conversations push proxy is used #1410
http upload is not working (paperclip icon not shown) in version 4.1.0 with my own server (ejabberd 18.12.1). There's the following line on the console:
The problem is due to discovery of http-upload feature failing and was introduced by commit 01f0a65.
After reverting this commit everything is fine and http upload works again.
@jcbrand After thinking about it for a while, I believe it would be best to simply revert commit 01f0a65 as it makes no sense to reject the
Previously, when the IQ request failed but we resolved instead of rejected the promise, then an empty Collection of features was created.
This was a problem for MUCs, because the MUC might not exist at that point yet, but will then be created, in which case Converse wrongly thinks the MUC has zero features.
So my initial idea was to reject the promise and then have proper error handling. I ended up solving the MUC issue a bit differently, but I still think rejecting makes more sense semantically and that the problem lies in the error handling instead.
Yes, but my current thinking is that Converse should deal with this via better error handling of the rejected promise, not by pretending that all is fine and creating an empty Features Collection which can cause confusion and false reporting down the road.