Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentions should include a URI attribute per XEP-0372 "References" #1495

Closed
guusdk opened this issue Mar 14, 2019 · 0 comments

Comments

@guusdk
Copy link
Member

commented Mar 14, 2019

https://xmpp.org/extensions/xep-0372.html:

References are provided in a 'reference' element of a message, with a namespace of 'urn:xmpp:reference:0'. The element MUST contain a type attribute denoting the type of the reference and a uri attribute of the thing that is referenced.

Converse doesn't include that URI attribute (in 4.1.0):

<body>Other than what's described in the XEP you mean, ralphm ?</body>
<active xmlns="http://jabber.org/protocol/chatstates"/>
<reference xmlns="urn:xmpp:reference:0" begin="49" end="55" type="mention"/>

@jcbrand jcbrand added the improvement label Jun 19, 2019

@jcbrand jcbrand closed this in 303a8b6 Jun 19, 2019

@jcbrand jcbrand added this to the 5.0.0 milestone Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.