Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clear localStorage and sessionStorage #1561

Closed
dickverweij opened this issue May 7, 2019 · 1 comment

Comments

@dickverweij
Copy link

commented May 7, 2019

We are currently testing the conversejs script "embedded" in our site. We found out than the script can call localStorage.clear() which deletes all of our own persistent data.

Is there a way to disable this behavior? Using localStorage is fine, but only clean what is used by converse....

@jcbrand

This comment has been minimized.

Copy link
Member

commented May 7, 2019

I'm aware of this issue and did some work in a branch to only clear the actual data from Converse and not everything else. However, it's not yet in master and will take some more time to get working properly.

@jcbrand jcbrand added the bug label May 9, 2019

@jcbrand jcbrand changed the title When using embedded, localstorage could be cleared Don't clear localStorage and sessionStorage Aug 1, 2019

@jcbrand jcbrand added this to the 5.0.0 milestone Aug 1, 2019

@jcbrand jcbrand closed this in cd392bb Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.