Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklisting converse-profile makes the control box totally blank #1664

Closed
reda-alaoui opened this issue Aug 3, 2019 · 2 comments · Fixed by #1665

Comments

@reda-alaoui
Copy link
Contributor

commented Aug 3, 2019

Describe the bug
Blacklisting converse-profile makes the control box totally blank

To Reproduce
Steps to reproduce the behavior:

  1. Blacklist converse-profile

Expected behavior
I was expecting to prevent the show-profile modale from being displayed.

Environment (please complete the following information):

  • Desktop
  • Chrome 75
  • Converse.js 4.2.0
@reda-alaoui

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2019

This is a follow up of #1662

@jcbrand jcbrand added the bug label Aug 3, 2019

@jcbrand

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

Thanks for making a bug report for this.

reda-alaoui added a commit to Cosium/converse.js that referenced this issue Aug 4, 2019
reda-alaoui added a commit to Cosium/converse.js that referenced this issue Aug 4, 2019
reda-alaoui added a commit to Cosium/converse.js that referenced this issue Aug 4, 2019

@jcbrand jcbrand closed this in #1665 Aug 5, 2019

jcbrand added a commit that referenced this issue Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.