Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: plugin._features is not a function #1712

Closed
Zash opened this issue Sep 12, 2019 · 4 comments

Comments

@Zash
Copy link
Contributor

commented Sep 12, 2019

Describe the bug

Saw this in the console while attempting to reproduce some other issue:

 FATAL: onDiscoInfoRequest@https://cdn.conversejs.org/5.0.2/dist/converse.js:52893:7
run@https://cdn.conversejs.org/5.0.2/dist/converse.js:45503:22
_dataRecv/<@https://cdn.conversejs.org/5.0.2/dist/converse.js:46744:29
forEachChild@https://cdn.conversejs.org/5.0.2/dist/converse.js:44501:17
_dataRecv@https://cdn.conversejs.org/5.0.2/dist/converse.js:46733:9
_onMessage@https://cdn.conversejs.org/5.0.2/dist/converse.js:49233:9
 converse.js:50665:5
 FATAL: error: undefined https://cdn.conversejs.org/5.0.2/dist/converse.js:52893 - TypeError: plugin._features is not a function converse.js:50665:5
	converse_core_converse.log https://cdn.conversejs.org/5.0.2/dist/converse.js:50665:5
	setUpXMLLogging/converse_core_Strophe.log https://cdn.conversejs.org/5.0.2/dist/converse.js:51062:5
	fatal https://cdn.conversejs.org/5.0.2/dist/converse.js:45063:9
	_handleError https://cdn.conversejs.org/5.0.2/dist/converse.js:44971:13
	run https://cdn.conversejs.org/5.0.2/dist/converse.js:45505:13
	_dataRecv/< https://cdn.conversejs.org/5.0.2/dist/converse.js:46744:29
	forEachChild https://cdn.conversejs.org/5.0.2/dist/converse.js:44501:17
	_dataRecv https://cdn.conversejs.org/5.0.2/dist/converse.js:46733:9
	_onMessage https://cdn.conversejs.org/5.0.2/dist/converse.js:49233:9

To Reproduce
Steps to reproduce the behavior:
Happens on https://chat.prosody.im/ which has configuration like this:

	converse.initialize({
		"allow_bookmarks" : false,
		"hide_muc_server" : true,
		"allow_contact_requests" : false,
		"allow_dragresize" : false,
		"allow_muc_invitations" : false,
		"authentication" : "anonymous",
		"auto_join_on_invite" : true,
		"auto_join_rooms" : [
			"chat@conference.example.com
		],
		"auto_login" : true,
		"auto_reconnect" : false,
		"show_controlbox_by_default":false,
		"blacklisted_plugins" : [
			"converse-carbons",
			"converse-bookmarks",
			"converse-omemo",
			"converse-register",
			"converse-controlbox"
		],
		"bosh_service_url" : "/bosh",
		"debug" : false,
		"jid" : "anon.prosody.im",
		"keepalive" : true,
		"message_carbons" : false,
		"show_send_button" : false,
		"use_emojione" : false,
		"view_mode" : "fullscreen",
		"websocket_url" : "wss://chat.example.org/ws"
	});

Screenshots

Environment (please complete the following information):

  • Firefox 60.9 ESR
  • Converse.js version 5.0.2
@Zash Zash changed the title ypeError: plugin._features is not a function TypeError: plugin._features is not a function Sep 12, 2019
@MotoGP-Fan

This comment has been minimized.

Copy link

commented Sep 14, 2019

Hi JC,
in addition to Zash's report: I also receive this error message - see first pic.

  • Prosody 0.11.2
  • Converse 5.0.3 on local installation
  • tested with non minified js+css
  • Firefox 69.0 + Chrome 77.0.3865.75

2019-09-14_Converse503-Fullscreen_Error-non-minified

  • 2nd test with minified js+css leads to another error. 1st error is not displayed anymore - pic 2.

2019-09-14_Converse503-Fullscreen_Error-minified


converse.initialize({
debug: true,
authentication: 'login',
bosh_service_url: 'https://example.de/http-bind',
locked_domain: 'example.de',
allow_registration: false,
show_send_button: true,
use_emojione: false,
roster_groups: true,
archived_messages_page_size: 25,
message_carbons: true,
theme: 'default',
view_mode: 'fullscreen',
});

@laszlovl

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

I'm guessing this is related to the following commit: 768ed4a#diff-43e51bd411c01988f495ddaaece16b2fL324

@mreid0345

This comment has been minimized.

Copy link

commented Sep 18, 2019

I think its a different issue. Its failing on n._features not plugin._features

@ThoreKr

This comment has been minimized.

Copy link

commented Oct 5, 2019

Will there be a release with this fix in the near future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.