Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification sound playing erroneusly #1714

Closed
licaon-kter opened this issue Sep 13, 2019 · 1 comment

Comments

@licaon-kter
Copy link
Contributor

commented Sep 13, 2019

HEAD (fe34b7e), Firefox 69

1:1 chat
User A Converse
User A Gajim
User B Conversations

User A writes in Converse, Converse plays a sound (user A presses enter in Firefox and Firefox makes a sound)
User A writes in Gajim, no sound
User B writes in Conversations, no sound

This appears to be reversed, I should be getting notifications ONLY when user B is writing, any other time (user A in Converse or user A in Gajim) Firefox should not notify/make a sound.

ChaosKid42 added a commit to ChaosKid42/converse.js that referenced this issue Sep 24, 2019
don't notify if only message delivery receipt
ChaosKid42 added a commit to ChaosKid42/converse.js that referenced this issue Sep 24, 2019
don't notify if only message delivery receipt
@jcbrand jcbrand closed this in bce8dc9 Sep 24, 2019
@jcbrand jcbrand added this to the 5.0.4 milestone Sep 24, 2019
@licaon-kter

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

Yup, appears fixed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.