Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with error about dist/website.css #2446

Closed
Zash opened this issue Apr 3, 2021 · 5 comments
Closed

Build fails with error about dist/website.css #2446

Zash opened this issue Apr 3, 2021 · 5 comments

Comments

@Zash
Copy link
Contributor

Zash commented Apr 3, 2021

Describe the bug
Build fails with error about dist/website.css. Incomplete fix for #2443 ?

To Reproduce
Steps to reproduce the behavior:

  1. docker run -i --rm -v $PWD:/home/node/${PWD##*/} -w /home/node/${PWD##*/} -u node:node --network host node:14 make

Error

./node_modules/.bin/node-sass --source-map true --include-path ./node_modules/ sass/website.scss dist/website.css
An output directory must be specified when compiling a directory
Makefile:147: recipe for target 'dist/website.css' failed
make: *** [dist/website.css] Error 1

Environment (please complete the following information):

  • Docker node:14 image
  • Converse.js 724a685
@Zash
Copy link
Contributor Author

Zash commented Apr 3, 2021

Why's website.css needed for make dist anyway?

@licaon-kter
Copy link
Contributor

Is the fix proposed in the other issue better?

@Zash
Copy link
Contributor Author

Zash commented Apr 3, 2021

What other issue? #2443 ? Wasn't that merged?

@licaon-kter
Copy link
Contributor

That one worked for me, yes.

But the in tree changes looked different (to my eyes on a first look, didn't get a chance to make yet)

@licaon-kter
Copy link
Contributor

Confirmed locally that the #2443 proposed fix is better, make dist produced minified files, current HEAD still does not.

@jcbrand jcbrand closed this as completed Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants