Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When joining a room, use the vCard name first, or if unset the localpart of the JID, or if anonymous remember when it was first asked #968

Closed
linkmauve opened this issue Dec 19, 2017 · 1 comment

Comments

@linkmauve
Copy link
Contributor

commented Dec 19, 2017

When a user joins multiple rooms, asking them every time what their nick is is cumbersome. It would be much better to default to a sensible value, while letting the user configure that.

jcbrand added a commit that referenced this issue May 24, 2018

jcbrand added a commit that referenced this issue May 24, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented May 24, 2018

Ok, so what happens now...

  1. First Converse checks whether the user has a nickname registered with the room.
  2. Then it checks if the user has a nickname set in their VCard.
  3. Then, if muc_nickname_from_jid is true, it will use the localpart of the JID
  4. Otherwise it renders the nickname form.

I don't think it's worth the extra hassle to remember the nickname if the user doesn't have it set in their VCard. If you don't want to be asked every time, then set your VCard (which can now be done in Converse).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.