New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the roster name or vCard nickname before falling back to vCard fullname or JID #1168

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
2 participants
@linkmauve
Contributor

linkmauve commented Aug 18, 2018

The order of vCard nickname and fullname is subject to debate, but I just copied what was done elsewhere in Converse. The roster override though should imo always be first.

@linkmauve linkmauve force-pushed the linkmauve:better-name-selection branch from 3fb3fce to 6f0252c Aug 18, 2018

@jcbrand jcbrand merged commit 958e8a9 into conversejs:master Aug 20, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jcbrand

This comment has been minimized.

Member

jcbrand commented Aug 20, 2018

Thanks

@linkmauve linkmauve deleted the linkmauve:better-name-selection branch Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment