It is disabled by default until more testing has been done, set
There is also the very big problem that the
There is also a bit of code duplication in it, this will be fixed in a
@linkmauve The login code is fairly complex because there are multiple different ways a user could log in.
They could log in manually with the login form or automatically via XHR-fetched credentials, config credentials passed in to
Also, the different login types happen at different times within startup/setup of the client.
Due to this there is no one place where login can happen. It can happen in
Manuel login happens in the authenticate method of the LoginPanel view in converse-controlbox.js
Automatic login happens in various places in converse-core.js, such as (but not only) the autoLogin method.
In all these methods, it's assumed that
I think we should rewrite the
That might not be enough yet, because the connection might still be instantiated in code at times when we don't have a JID, but I think it's a good first step and those problematic cases will then have to be refactored somehow.
It is disabled by default until more testing has been done, set use_xep_0156 to true for now. There is also the very big problem that the `Strophe.Connection` is created before the user has had the time to enter their JID, which is why we currently hardcode the domain to be resolved (this MUST be fixed before this can be merged). I haven’t been able to figure out where to move this Connection creation, which must be after the JID is known but before the actual connection is attempted. There is also a bit of code duplication in it, this will be fixed in a future version of this commit. Fixes #129. Fixes #1109.