Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
WIP: Add support for XEP-0156 #1170
It is disabled by default until more testing has been done, set
There is also the very big problem that the
There is also a bit of code duplication in it, this will be fixed in a
@linkmauve The login code is fairly complex because there are multiple different ways a user could log in.
They could log in manually with the login form or automatically via XHR-fetched credentials, config credentials passed in to
Also, the different login types happen at different times within startup/setup of the client.
Due to this there is no one place where login can happen. It can happen in
Manuel login happens in the authenticate method of the LoginPanel view in converse-controlbox.js
Automatic login happens in various places in converse-core.js, such as (but not only) the autoLogin method.
In all these methods, it's assumed that
I think we should rewrite the
That might not be enough yet, because the connection might still be instantiated in code at times when we don't have a JID, but I think it's a good first step and those problematic cases will then have to be refactored somehow.