Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display MAM logs before joining the MUC #1266

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@linkmauve
Copy link
Contributor

commented Oct 24, 2018

The location of the nickname prompt has been moved to replace the message input, like in most Slack clones.

This allows visitors to view MAM logs before deciding whether they want to join the MUC or not.

@jcbrand jcbrand force-pushed the conversejs:master branch 2 times, most recently from 81498d6 to 6bab16d Oct 29, 2018

@linkmauve linkmauve force-pushed the linkmauve:non-joined-mam branch from 1c950e6 to ce869dd Nov 3, 2018

Display MAM logs before joining the MUC
The location of the nickname prompt has been moved to replace the
message input, like in most Slack clones.

This allows visitors to view MAM logs before deciding whether they want
to join the MUC or not.

@linkmauve linkmauve force-pushed the linkmauve:non-joined-mam branch from ce869dd to 57641e5 Nov 14, 2018

@jcbrand jcbrand force-pushed the conversejs:master branch 3 times, most recently from 8ca2731 to f16b6d2 Jan 2, 2019

@linkmauve

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

This should be a “Join groupchat” button, which opens the nickname modal.

@jcbrand

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

This should be a “Join groupchat” button, which opens the nickname modal.

Otherwise confused outside think it's the message input and type their first message in there

@jcbrand jcbrand force-pushed the conversejs:master branch 2 times, most recently from d9824b4 to c403708 Feb 5, 2019

@jcbrand jcbrand force-pushed the conversejs:master branch 2 times, most recently from 04f88d1 to 3e4f4e9 Feb 18, 2019

@jcbrand jcbrand force-pushed the conversejs:master branch from cbd2e47 to a0f5dfd Mar 15, 2019

@jcbrand jcbrand force-pushed the conversejs:master branch 2 times, most recently from 37cfa36 to f1899d0 Apr 10, 2019

jcbrand added a commit that referenced this pull request Jul 3, 2019

Fetch messages after fetching members.
This is done to avoid unnecessary repaints and reflows (caused when a
message has already rendered and then an occupant is created and
attached to that message, cauring a re-render).

Related to #1266

jcbrand added a commit that referenced this pull request Jul 4, 2019

Fetch messages after fetching members.
This is done to avoid unnecessary repaints and reflows (caused when a
message has already rendered and then an occupant is created and
attached to that message, cauring a re-render).

Related to #1266

@jcbrand jcbrand force-pushed the conversejs:master branch from 6a1d4ec to a1630b5 Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.