Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from SASS variables to CSS custom properties #1268

Merged
merged 2 commits into from Nov 2, 2018

Conversation

@linkmauve
Copy link
Contributor

commented Oct 25, 2018

This will eventually allow client-side theming support.

Supersedes #1267.

@linkmauve linkmauve force-pushed the custom-properties branch 4 times, most recently from 58cd9df to 9531694 Oct 25, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented Oct 28, 2018

Thanks a lot for this! I'll look into merging after the next release.

@jcbrand jcbrand force-pushed the master branch 2 times, most recently from 81498d6 to 6bab16d Oct 29, 2018

Switch from SASS variables to CSS custom properties
This will eventually allow client-side theming support.

@jcbrand jcbrand merged commit 37bd332 into master Nov 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jcbrand

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

Great work on this, thanks.

Unfortunately looks like the Sass variables also applied to the bootstrap sass files, but now with the CSS properties the bootstrap styles get their original colours (look for example at the badges).

We'll have to add some new css rules to make up for that.

@jcbrand jcbrand deleted the custom-properties branch Nov 2, 2018

@linkmauve

This comment has been minimized.

Copy link
Contributor Author

commented Nov 3, 2018

We could also keep defining the SASS variables, but this means we won’t be able to redefine them in a theme and that could be bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.