Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option "notification_requires_interaction" #1306

Merged

Conversation

@ChaosKid42
Copy link
Contributor

commented Nov 4, 2018

This PR introduces an option notification_requires_interaction which if enabled makes the notifications stay until explicitly dismissed by the user.

@ChaosKid42 ChaosKid42 force-pushed the ChaosKid42:notification_requires_interaction branch from a50d553 to 3247ea1 Nov 5, 2018

@jcbrand

This comment has been minimized.

Copy link
Member

commented Nov 5, 2018

Thanks @ChaosKid42!

I have a different suggestion however.

We can make the 5000ms value configurable with 5000 the default and with 0 meaning that the message doesn't disappear.

That way your feature becomes available and its possible to change the timeout to something else. Two birds with one stone :)

What do you think?

@ChaosKid42 ChaosKid42 force-pushed the ChaosKid42:notification_requires_interaction branch from 3247ea1 to 9005e3b Nov 5, 2018

@ChaosKid42

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2018

@jcbrand Great idea. Changed the PR accordingly.

@jcbrand jcbrand merged commit 1bdb171 into conversejs:master Nov 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jcbrand

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

Thanks!

@ChaosKid42 ChaosKid42 deleted the ChaosKid42:notification_requires_interaction branch Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.