Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show version info in login dialog #1316

Merged
merged 1 commit into from Nov 14, 2018

Conversation

@ChaosKid42
Copy link
Contributor

commented Nov 9, 2018

I propose to show a small text showing the version of converse.

@ChaosKid42 ChaosKid42 force-pushed the ChaosKid42:show_version branch 6 times, most recently from ca00766 to 57d8c8c Nov 9, 2018

@jcbrand jcbrand force-pushed the conversejs:master branch from 0bffcd6 to d2b0fa7 Nov 12, 2018

@ChaosKid42 ChaosKid42 force-pushed the ChaosKid42:show_version branch 5 times, most recently from 83d0798 to 7917cf5 Nov 12, 2018

@@ -213,6 +213,8 @@ converse.plugins.add('converse-controlbox', {
this.model.set('closed', !_converse.show_controlbox_by_default);
}
}
this.model.set('version_name', _converse.VERSION_NAME);
this.model.set('view_mode', _converse.view_mode);

This comment has been minimized.

Copy link
@jcbrand

jcbrand Nov 13, 2018

Member

Instead of setting version_name on the model, you can just pass it in to tpl_controlbox.

I think that's better, because it's a constant, so it seems a bit weird to put it in the model which contains variable data.

Same with view_mode.

This comment has been minimized.

Copy link
@ChaosKid42

ChaosKid42 Nov 13, 2018

Author Contributor

👍

@ChaosKid42 ChaosKid42 force-pushed the ChaosKid42:show_version branch from 7917cf5 to 9a307da Nov 13, 2018

@jcbrand jcbrand merged commit 0baed97 into conversejs:master Nov 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ChaosKid42 ChaosKid42 deleted the ChaosKid42:show_version branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.